Fix for https://github.com/Qiskit/qiskit-aer/issues/2235 #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lls for a MPS simulator return the wrong ordering for states"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AerState::probability and AerState::amplitude calls for a MPS simulator return the wrong ordering for states
Summary
The MPS simulator returned the wrong states amplitudes and probabilities with AerState::probability and AerState::amplitude calls.
Details and comments
The values were correct, but for the wrong states, the reason being the order of qubits.
The fix is by adding a function
reorder_qubits_revthat provides the correct order of qubits and by modifyingMPS::get_amplitude_vectorto call it instead of the original call toreorder_qubits.More details on the issue description and in the comments: #2235