-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix init of EstimatorV2 and SamplerV2 #2120
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fee8d6c
fix init of EstimatorV2 and SamplerV2 to handle method
doichanj a728234
add release note
doichanj aef108a
fix from_backend and example in README
doichanj cf6c839
Merge remote-tracking branch 'upstream/main' into fix_primitiveV2_init
doichanj 6eb0655
remove setting density_matrix
doichanj 2ddb201
Merge remote-tracking branch 'upstream/main' into fix_primitiveV2_init
doichanj c82ed0b
Merge remote-tracking branch 'upstream/main' into fix_primitiveV2_init
doichanj 8306a7e
Merge remote-tracking branch 'upstream/main' into fix_primitiveV2_init
doichanj 8ae2f3a
Merge remote-tracking branch 'upstream/main' into fix_primitiveV2_init
doichanj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,6 +98,12 @@ def __init__( | |
self._seed = seed | ||
|
||
self._options = Options(**options) if options else Options() | ||
if "method" not in self.options.backend_options: | ||
method = ( | ||
"density_matrix" if "noise_model" in self.options.backend_options else "automatic" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does this mean that noise simulation always use "density_matrix" in sampler? |
||
) | ||
ops = dict(method=method) | ||
self.options.backend_options.update(ops) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
may be simpler. |
||
self._backend = AerSimulator(**self.options.backend_options) | ||
|
||
def from_backend(self, backend, **options): | ||
|
5 changes: 5 additions & 0 deletions
5
releasenotes/notes/fix_primitiveV2_init-afe7b331ddbef538.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
fixes: | ||
- | | ||
Fixed init function of EstimatorV2 and SamplerV2 to set `method` in | ||
its option property if there is no `method` in input parameter |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this line necessary? Shouldn't we just let AerSimulator set the method if it's not specified? It should default to
automatic
, which should be smart enough to choosedensity_matrix
ifnoise_model
is specified.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this so now
method=automatic
is set by default and #2117 is fixed