Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name of AerSimulator generated by AerProvider #2038

Merged
merged 13 commits into from
Mar 21, 2024
Merged

Fix name of AerSimulator generated by AerProvider #2038

merged 13 commits into from
Mar 21, 2024

Conversation

doichanj
Copy link
Collaborator

Summary

This PR is fix for definitions of name of AerSimulator genrated by AerProvider.
Fix for comment on #2037

Details and comments

AerSimulator generated from AerProvider has the same name aer_simulator since AerBackend was upgraded to V2 backend.

Also, tensor_network method is not enumerated by AerProvider

@doichanj doichanj added stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the Fixed section of the changelog labels Jan 23, 2024
mtreinish
mtreinish reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change LGTM, but could you add a unit test to validate the names are generated correctly just so we don't regress here in the future?

@doichanj doichanj requested a review from mtreinish January 24, 2024 16:02
@jakelishman jakelishman mentioned this pull request Jan 25, 2024
Closed
@jakelishman jakelishman linked an issue Jan 25, 2024 that may be closed by this pull request
Aer.backends returns repeated backends #2039
Closed
@doichanj doichanj added this to the Aer 0.14.0 milestone Feb 20, 2024
@doichanj doichanj mentioned this pull request Mar 18, 2024
Merged
hhorii
hhorii approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@hhorii hhorii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhorii hhorii merged commit 7ea1c1a into Qiskit:main Mar 21, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhorii hhorii hhorii approved these changes

@mtreinish mtreinish Awaiting requested review from mtreinish

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Milestone
Aer 0.14.0
Development

Successfully merging this pull request may close these issues.

Aer.backends returns repeated backends
3 participants
@doichanj @mtreinish @hhorii