Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case to serialize result of simulation #1869

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

hhorii
Copy link
Collaborator

@hhorii hhorii commented Jul 11, 2023

Summary

Add a test case to check serialization of simulation result

Details and comments

This PR adds a test case to check serialization of simulation result work well.

@hhorii hhorii added the Changelog: None PRs that don't have an associated changelog entry. label Jul 11, 2023
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good idea, thanks. Could we add a test that the result object can roundtrip through pickle as well, while we're at it? I imagine that anything that can roundtrip JSON can roundtrip pickle, but it'd be good to be explicit.

@hhorii
Copy link
Collaborator Author

hhorii commented Oct 6, 2023

@jakelishman sorry that my response is lazy. I added pickle test case.

@doichanj doichanj added the automerge This PR will automatically merge once its CI has passed label Oct 10, 2023
@mergify mergify bot merged commit 64a9696 into Qiskit:main Oct 10, 2023
32 checks passed
doichanj added a commit to doichanj/qiskit-aer that referenced this pull request Oct 26, 2023
* add test case to serialize result of simulation

* add pickle comparison

---------

Co-authored-by: Jun Doi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge This PR will automatically merge once its CI has passed Changelog: None PRs that don't have an associated changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants