Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a work around for Aer installation issue in Neko #1703

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

hhorii
Copy link
Collaborator

@hhorii hhorii commented Jan 24, 2023

Summary

This PR can resolve CI fail of a Neko with a work around

Details and comments

pip install . fails in Neko's github action though it is successful in local environment.
conan commands can not be found in the action though it is installed.
This PR is a work around to fix the current issue in Neko by manually installing conan.

This is from #1699.

@hhorii hhorii added this to the Aer 0.12.0 milestone Jan 24, 2023
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this as a solution. This is masking something that I think is wrong with aer's build configuration. Conan is getting installed by pip (as it's listed in the pyproject.toml as a build requirement), so if it's not being found that's likely an issue with our cmake files. That being said I don't have sufficient time to dig into what's going wrong here, so we can do this as a short term fix to unblock ci. But before we merge this can you open an issue to track the underlying issue so we can remove this hack when that's fixed.

@hhorii hhorii added the automerge This PR will automatically merge once its CI has passed label Jan 31, 2023
@mergify mergify bot merged commit a93390c into Qiskit:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge This PR will automatically merge once its CI has passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants