Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add run_subcircuits_using_sampler function #72

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Add run_subcircuits_using_sampler function #72

merged 1 commit into from
Mar 31, 2023

Conversation

garrison
Copy link
Member

This allows someone to run the subcircuits using the Sampler of their choice, i.e., not limited to choosing between qiskit.primitives and qiskit_ibm_runtime.

@garrison
Add run_subcircuits_using_sampler function
957ee85 
This allows someone to run the subcircuits using the `Sampler` of their
choice, i.e., not limited to choosing between `qiskit.primitives` and
`qiskit_ibm_runtime`.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4566410213

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.795%
Changes Missing Coverage Covered Lines Changed/Added Lines %
circuit_knitting_toolbox/circuit_cutting/wire_cutting/wire_cutting_evaluation.py 6 8 75.0%
Totals Coverage Status
Change from base Build 4566240604: 0.02%
Covered Lines: 1528
Relevant Lines: 1802
💛 - Coveralls

@garrison garrison requested a review from caleb-johnson March 30, 2023 19:36
caleb-johnson
caleb-johnson approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GTM, thanks 👍

@garrison garrison merged commit f978a70 into main Mar 31, 2023
@garrison garrison deleted the run_subcircuits_using_sampler branch March 31, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleb-johnson caleb-johnson caleb-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrison @coveralls @caleb-johnson