Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken external docs links #699

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

These were caught by the qiskit/documentation external link checker.

@Eric-Arellano Eric-Arellano added the stable backport potential Suitable to be backported to most recent stable branch by Mergify label Oct 29, 2024
@@ -142,7 +142,7 @@ class ExactSampler(BaseSamplerV1):
:mod:`qiskit_aer.primitives` do not currently support all of the above
functionality. Related upstream issues:

- https://github.com/Qiskit/qiskit-terra/issues/9657
- https://github.com/Qiskit/qiskit/issues/9657
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link checker doesn't like redirects

@@ -32,7 +32,7 @@ issues:
The :mod:`~circuit_knitting_toolbox.circuit_cutting` package only supports :class:`~qiskit.quantum_info.PauliList` observables for calculating expectation values. Support for calculating
expectation values for more observable types, including :class:`~qiskit.quantum_info.SparsePauliOp`, is expected no sooner than 0.3.0.
- |
The ``Sampler``\ s from Qiskit and Qiskit Aer do not support mid-circuit measurements in statevector mode. For more on generating exact quasi-distributions using the :class:`~qiskit.primitives.BaseSampler` interface, check out our `how-to guide <https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/tree/main/docs/circuit_cutting/how-tos/how_to_generate_exact_quasi_dists_from_sampler.ipynb>`_.
The ``Sampler``\ s from Qiskit and Qiskit Aer do not support mid-circuit measurements in statevector mode. For more on generating exact quasi-distributions using the :class:`~qiskit.primitives.BaseSampler` interface, check out our `how-to guide <https://github.com/Qiskit/qiskit-addon-cutting/blob/stable/0.7/docs/circuit_cutting/how-tos/how_to_generate_exact_quasi_dists_from_sampler.ipynb>`_.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this note is for 0.2, but I linked to 0.7 so it's more recent. Lmk if I should link to 0.9. The most important thing is to use a stable branch because main will soon-ish not have non-API docs

@@ -4,4 +4,4 @@ deprecations:
The ``circuit_knitting.cutting.cutqc`` package is deprecated and will be removed no sooner than Circuit Knitting Toolbox 0.8.0.
The wire cutting functionality in the :mod:`circuit_knitting.cutting` package is what will be maintained going forward.
Additionally, there is a new automated gate and wire cut-finding functionality in the :mod:`circuit_knitting.cutting.automated_cut_finding` module.
A `tutorial <https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/blob/main/docs/circuit_cutting/tutorials/04_automatic_cut_finding.ipynb>`__ has been added to demonstrate automated cut-finding.
A `tutorial <https://github.com/Qiskit/qiskit-addon-cutting/blob/stable/0.7/docs/circuit_cutting/tutorials/04_automatic_cut_finding.ipynb>`__ has been added to demonstrate automated cut-finding.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto if you want this to be stable/0.9

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11580286317

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11508901522: 0.0%
Covered Lines: 2330
Relevant Lines: 2330

💛 - Coveralls

Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Eric-Arellano Eric-Arellano merged commit 10746c0 into Qiskit:main Oct 29, 2024
11 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/fix-external-links branch October 29, 2024 20:22
mergify bot pushed a commit that referenced this pull request Oct 29, 2024
These were caught by the qiskit/documentation external link checker.

(cherry picked from commit 10746c0)
Eric-Arellano added a commit that referenced this pull request Oct 29, 2024
These were caught by the qiskit/documentation external link checker.

(cherry picked from commit 10746c0)

Co-authored-by: Eric Arellano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable backport potential Suitable to be backported to most recent stable branch by Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants