Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ruff==0.5.1 #640

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Pin ruff==0.5.1 #640

merged 1 commit into from
Jul 16, 2024

Conversation

garrison
Copy link
Member

We pin most of our linters, but we have gotten away so far without pinning ruff. However, today CI is broken because the ruff 0.5.2 (patchlevel) release seems to have added a rule. (Or maybe it fixed a rule that was broken before. Either way, it broke us.)

From here forward, let's pin ruff, too, and dependabot can propose updating the version from time to time, just as it does with the other linters.

We pin most of our linters, but we have gotten away so far without
pinning ruff.  However, today CI is broken because the ruff 0.5.2
(patchlevel) release seems to have added a rule.  (Or maybe it
fixed a rule that was broken before.  Either way, it broke us.)

From here forward, let's pin ruff, too, and dependabot can propose
updating the version from time to time, just as it does with the
other linters.
@garrison garrison added dependencies Pull requests that update a dependency file cicd Related to the CICD pipeline stable backport potential Suitable to be backported to most recent stable branch by Mergify labels Jul 16, 2024
@garrison garrison added this to the 0.7.3 milestone Jul 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9958124234

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9875836298: 0.0%
Covered Lines: 2410
Relevant Lines: 2410

💛 - Coveralls

@garrison garrison merged commit 250e61a into main Jul 16, 2024
11 checks passed
@garrison garrison deleted the pin-ruff branch July 16, 2024 14:26
mergify bot pushed a commit that referenced this pull request Jul 16, 2024
We pin most of our linters, but we have gotten away so far without
pinning ruff.  However, today CI is broken because the ruff 0.5.2
(patchlevel) release seems to have added a rule.  (Or maybe it
fixed a rule that was broken before.  Either way, it broke us.)

From here forward, let's pin ruff, too, and dependabot can propose
updating the version from time to time, just as it does with the
other linters.

(cherry picked from commit 250e61a)
garrison added a commit that referenced this pull request Jul 16, 2024
We pin most of our linters, but we have gotten away so far without
pinning ruff.  However, today CI is broken because the ruff 0.5.2
(patchlevel) release seems to have added a rule.  (Or maybe it
fixed a rule that was broken before.  Either way, it broke us.)

From here forward, let's pin ruff, too, and dependabot can propose
updating the version from time to time, just as it does with the
other linters.

(cherry picked from commit 250e61a)

Co-authored-by: Jim Garrison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Related to the CICD pipeline dependencies Pull requests that update a dependency file stable backport potential Suitable to be backported to most recent stable branch by Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants