Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove basepython restriction in lint and coverage environments #612

Merged
merged 1 commit into from
May 31, 2024
Merged

Remove basepython restriction in lint and coverage environments #612

merged 1 commit into from
May 31, 2024

Conversation

garrison
Copy link
Member

@garrison garrison commented May 30, 2024 •
edited
Loading

This restriction was previously necessary, but it no longer appears to be, as far as I can tell.

Getting rid of the restriction will make these environments work on systems where python3.10 is not installed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9309068398

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9306464756: 0.0%
Covered Lines: 2401
Relevant Lines: 2401
💛 - Coveralls

@garrison garrison marked this pull request as ready for review May 30, 2024 21:06
@garrison garrison requested a review from caleb-johnson May 31, 2024 01:07
caleb-johnson
caleb-johnson approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool LGTM

@garrison garrison merged commit 7029c10 into main May 31, 2024
11 checks passed
@garrison garrison deleted the basepython-restriction branch May 31, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleb-johnson caleb-johnson caleb-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrison @coveralls @caleb-johnson