Remove use of qasm simulator #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #502.
garrison
added
the
cutqc
garrison
commented
May 15, 2024
Comment on lines
84
to
85
| backend_names_repeated = ["ibmq_qasm_simulator"] * len(subcircuits) | ||
| least_busy = service.least_busy().name | ||
| backend_names_repeated = [least_busy] * len(subcircuits) |
There was a problem hiding this comment.
Actually, I am going to change this to restore the old code path and just put a warning right before it. I am doing this with the typical persona of somebody using this (deprecated) code in mind. If I were using cutqc still, I'd be very surprised if I upgraded and my old code that used a cloud qasm simulator suddenly uses a hardware backend instead. Better is for the user to have an error occur, and to be able to deal with it as they see fit. With the warning, they'll have a bit more context for why the qasm simulator is suddenly failing and what to do to fix it (pass backend_names).
There was a problem hiding this comment.
Updated accordingly in 2d27024.
garrison
added
the
stable backport potential
Pull Request Test Coverage Report for Build 9099267395Details
💛 - Coveralls |
garrison
added a commit
that referenced
this pull request
May 15, 2024
* Remove use of qasm simulator Closes #502. * Replace default configuration change with a warning * Add `stacklevel` to warning (cherry picked from commit e3db27b) Co-authored-by: Jim Garrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #502.
I had not noticed before, but the section on setting up the sampler primitive appears twice in the second cutqc tutorial. So I was able to remove the first appearance.