Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force at least one classical bit in qpd_measurements register #563

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

garrison
Copy link
Member

@garrison garrison commented Apr 24, 2024

Fixes #564

This is a potential workaround to openqasm/qe-qasm#37

@garrison garrison added bug Something isn't working cutting QPD-based circuit cutting code labels Apr 24, 2024
@coveralls
Copy link

coveralls commented Apr 24, 2024

Pull Request Test Coverage Report for Build 8825413156

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.484%

Totals Coverage Status
Change from base Build 8821415721: 0.0%
Covered Lines: 3489
Relevant Lines: 3654

💛 - Coveralls

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Should probably add a release note

(EDIT): Just saw this is still in draft :)

@garrison garrison marked this pull request as ready for review April 25, 2024 01:12
@garrison garrison requested a review from caleb-johnson April 25, 2024 01:13
@garrison garrison mentioned this pull request Apr 25, 2024
12 tasks
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@garrison garrison merged commit 06cebeb into main Apr 25, 2024
11 checks passed
@garrison garrison deleted the nonzero-register-size branch April 25, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cutting QPD-based circuit cutting code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subexperiments don't run on real QPUs
3 participants