Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No worktrees #559

Merged
merged 5 commits into from
Apr 23, 2024
Merged

No worktrees #559

merged 5 commits into from
Apr 23, 2024

Conversation

caleb-johnson
Copy link
Collaborator

@caleb-johnson caleb-johnson commented Apr 23, 2024

Fixes #557

There is a problem with dulwich (used by reno) and git worktrees. This PR implements a temporary fix, spelled out here.

@caleb-johnson caleb-johnson requested a review from garrison April 23, 2024 00:03
@coveralls
Copy link

coveralls commented Apr 23, 2024

Pull Request Test Coverage Report for Build 8793387891

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.438%

Totals Coverage Status
Change from base Build 8757556858: 0.0%
Covered Lines: 3452
Relevant Lines: 3617

💛 - Coveralls

@garrison
Copy link
Member

Thank you for tracking this down. If I understand correctly, we should be able to revert this once upstream is fixed; is that correct?

garrison
garrison previously approved these changes Apr 23, 2024
@caleb-johnson
Copy link
Collaborator Author

Thank you for tracking this down. If I understand correctly, we should be able to revert this once upstream is fixed; is that correct?

Yes it seems to me the fix was very simple and should be there next dulwich release

@caleb-johnson caleb-johnson merged commit 0d9cb60 into main Apr 23, 2024
11 checks passed
@caleb-johnson caleb-johnson deleted the no-worktrees branch April 23, 2024 01:35
garrison added a commit that referenced this pull request Apr 24, 2024
caleb-johnson pushed a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs build failing on main branch
3 participants