Enable pylint's dangerous-default-value
check
#544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran pylint in its default configuration, I noticed a few
dangerous-default-value
warnings in the new cut finder. I think it's worth adding this to our pylint configuration and fixing the existing issues in the code base. (Even though users aren't supposed to directly call this code, adding this to our config allows us to prevent similar dangerous defaults in places we do care about.)