Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pylint's dangerous-default-value check #544

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

garrison
Copy link
Member

When I ran pylint in its default configuration, I noticed a few dangerous-default-value warnings in the new cut finder. I think it's worth adding this to our pylint configuration and fixing the existing issues in the code base. (Even though users aren't supposed to directly call this code, adding this to our config allows us to prevent similar dangerous defaults in places we do care about.)

@coveralls
Copy link

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8668017661

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 95.438%

Totals Coverage Status
Change from base Build 8664308665: 0.005%
Covered Lines: 3452
Relevant Lines: 3617

💛 - Coveralls

@garrison garrison added the code quality Related to style, linters, etc. label Apr 12, 2024
Copy link
Collaborator

@ibrahim-shehzad ibrahim-shehzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I had to look at the examples given here to understand what the potential danger was but this makes sense now. I made a minor modification to one of the tests and a docstring, just to make sure everything was consistent. This looks good to me overall, thanks

@garrison garrison merged commit a12b9a5 into main Apr 12, 2024
10 of 11 checks passed
@garrison garrison deleted the pylint-dangerous-default-value branch April 12, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Related to style, linters, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants