Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff config #478

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Update ruff config #478

merged 2 commits into from
Feb 7, 2024

Conversation

caleb-johnson
Copy link
Collaborator

ruff wants us to use the lint package in these two spots. This PR just removes a couple of warnings from our lint CI job

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `.ruff.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'per-file-ignores' -> 'lint.per-file-ignores'

@coveralls
Copy link

coveralls commented Feb 7, 2024

Pull Request Test Coverage Report for Build 7820813932

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.498%

Totals Coverage Status
Change from base Build 7820250860: 0.0%
Covered Lines: 2984
Relevant Lines: 3226

💛 - Coveralls

garrison
garrison previously approved these changes Feb 7, 2024
Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have noticed these warnings too. This LGTM. I added one suggestion, which is optional. (Hopefully it doesn't break anything if you apply it.)

.ruff.toml Outdated Show resolved Hide resolved
Co-authored-by: Jim Garrison <[email protected]>
@caleb-johnson caleb-johnson merged commit ba513bf into main Feb 7, 2024
11 checks passed
@caleb-johnson caleb-johnson deleted the ruff-updates branch February 7, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants