Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Session.from_id() method in qiskit-ibm-runtime #421

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

garrison
Copy link
Member

This removes the places where we modify the private member session._session_id, which is possible now that Qiskit/qiskit-ibm-runtime#1101 has been merged. We'll have to wait for it to be included in a release (and at that time bump the required qiskit-ibm-runtime version number), hence the "on hold" label.

@garrison garrison added on hold Let's wait for something before merging forging labels Sep 27, 2023
@coveralls
Copy link

coveralls commented Sep 27, 2023

Pull Request Test Coverage Report for Build 6709742561

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 92.442%

Changes Missing Coverage Covered Lines Changed/Added Lines %
circuit_knitting/forging/entanglement_forging_knitter.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
circuit_knitting/forging/entanglement_forging_knitter.py 1 86.48%
Totals Coverage Status
Change from base Build 6708466730: 0.06%
Covered Lines: 2960
Relevant Lines: 3202

💛 - Coveralls

@garrison
Copy link
Member Author

We should also test it in a notebook before merging, since these lines are not picked up by CI.

qiskit-ibm-runtime depends on qiskit>0.44.1, so we are forced to
bump qiskit as well for the minimum version tests to pass.
rustworkx 0.13 is required by qiskit 0.44.1
@garrison
Copy link
Member Author

The version of qiskit-ibm-runtime we now require depends on qiskit>0.44.1, so we are forced to bump qiskit (and also rustworkx) as well for the minimum version tests to pass.

@garrison garrison added this to the 0.6.0 milestone Oct 11, 2023
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! LGTM

@garrison garrison removed the on hold Let's wait for something before merging label Nov 7, 2023
@garrison
Copy link
Member Author

garrison commented Nov 7, 2023

I set service equal to something other than None and confirmed that this works with Qiskit Runtime -- and that all relevant code paths are executed by the tutorial notebook.

@garrison garrison merged commit d855eac into main Nov 7, 2023
@garrison garrison deleted the session_from_id branch November 7, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants