-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new Session.from_id()
method in qiskit-ibm-runtime
#421
Conversation
Pull Request Test Coverage Report for Build 6709742561
💛 - Coveralls |
We should also test it in a notebook before merging, since these lines are not picked up by CI. |
qiskit-ibm-runtime depends on qiskit>0.44.1, so we are forced to bump qiskit as well for the minimum version tests to pass.
rustworkx 0.13 is required by qiskit 0.44.1
The version of qiskit-ibm-runtime we now require depends on qiskit>0.44.1, so we are forced to bump qiskit (and also rustworkx) as well for the minimum version tests to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! LGTM
I set |
This removes the places where we modify the private member
session._session_id
, which is possible now that Qiskit/qiskit-ibm-runtime#1101 has been merged. We'll have to wait for it to be included in a release (and at that time bump the required qiskit-ibm-runtime version number), hence the "on hold" label.