Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the cutting workflow work with any Hashable as label #410

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

garrison
Copy link
Member

@garrison garrison commented Sep 9, 2023

Fixes #390

  • Add a test

I'm leaning against adding a release note, because I don't see any reason to draw attention to this. This is mostly a conceptual cleanup.

@garrison garrison added enhancement New feature or request cutting QPD-based circuit cutting code labels Sep 9, 2023
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Pull Request Test Coverage Report for Build 6128602231

  • 31 of 31 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 91.893%

Totals Coverage Status
Change from base Build 6127267950: -0.002%
Covered Lines: 2947
Relevant Lines: 3207

💛 - Coveralls

@garrison garrison marked this pull request as ready for review September 11, 2023 01:41
@caleb-johnson
Copy link
Collaborator

So basically, we have moved entirely to dictionary/single-instance representations throughout our workflow, so there is no longer any need to sort anything. Is that right?

@garrison
Copy link
Member Author

So basically, we have moved entirely to dictionary/single-instance representations throughout our workflow, so there is no longer any need to sort anything. Is that right?

Yes

caleb-johnson
caleb-johnson previously approved these changes Sep 11, 2023
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this. Nice to have this typing discrepancy shored up :)

@garrison garrison merged commit 48f1e04 into main Sep 11, 2023
9 checks passed
@garrison garrison deleted the workflow-hashable branch September 11, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cutting QPD-based circuit cutting code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cutting workflow should work with any Hashable as labels
2 participants