Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework tutorials to use the new workflow #404

Merged
merged 11 commits into from
Sep 12, 2023
Merged

Rework tutorials to use the new workflow #404

merged 11 commits into from
Sep 12, 2023

Conversation

caleb-johnson
Copy link
Collaborator

@caleb-johnson caleb-johnson commented Sep 5, 2023 •
edited
Loading

Fixes #351 Fixes #363

Needs #391

@caleb-johnson caleb-johnson added the cutting QPD-based circuit cutting code label Sep 5, 2023
@caleb-johnson caleb-johnson added this to the 0.4.0 milestone Sep 5, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6125668669

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.9%
Totals Coverage Status
Change from base Build 6125658967: 0.0%
Covered Lines: 2950
Relevant Lines: 3210
💛 - Coveralls

@caleb-johnson caleb-johnson marked this pull request as ready for review September 8, 2023 21:04
@garrison
Copy link
Member

IMO this PR is also is the last step toward fixing #363.

garrison added a commit that referenced this pull request Sep 11, 2023
@garrison
Deprecate execute_experiments()
06500ba 
Fixes #405.

The last sentence in this PR's release note will become true as soon
as #404 is merged.
garrison added a commit that referenced this pull request Sep 11, 2023
@garrison
Deprecate execute_experiments()
af61538 
Fixes #405.

The last sentence in this PR's release note will become true as soon
as #404 is merged.
garrison added a commit that referenced this pull request Sep 11, 2023
@garrison
Deprecate execute_experiments()
b277dff 
Fixes #405.

The last sentence in this PR's release note will become true as soon
as #404 is merged.
garrison added a commit that referenced this pull request Sep 11, 2023
@garrison
Deprecate execute_experiments()
38e7c77 
Fixes #405.

The last sentence in this PR's release note will become true as soon
as #404 is merged.
@garrison garrison mentioned this pull request Sep 11, 2023
Merged
1 task
garrison
garrison previously approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great. The only thing that stood out to me is the qc_0 in the first tutorial.

garrison added a commit that referenced this pull request Sep 12, 2023
@garrison
Deprecate execute_experiments() (#413)
26e58eb 
* Deprecate `execute_experiments()`

Fixes #405.

The last sentence in this PR's release note will become true as soon
as #404 is merged.

* Update how-tos to avoid calling `execute_experiments()`
@caleb-johnson caleb-johnson merged commit 5224cda into main Sep 12, 2023
@caleb-johnson caleb-johnson deleted the tutorial-rework branch September 12, 2023 20:06
@garrison garrison mentioned this pull request Mar 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrison garrison garrison approved these changes

Assignees
No one assigned
Labels
cutting QPD-based circuit cutting code
Projects
None yet
Milestone
0.4.0
3 participants
@caleb-johnson @coveralls @garrison