Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public generate_cutting_experiments function #385

Merged
merged 42 commits into from
Aug 31, 2023
Merged

Conversation

caleb-johnson
Copy link
Collaborator

@caleb-johnson caleb-johnson commented Aug 29, 2023

This should be the first PR to be merged into main based on #352 .

This creates a public function generate_cutting_experiments which largely mimics the current private function of the same name in cutting_evaluation.

@coveralls
Copy link

coveralls commented Aug 29, 2023

Pull Request Test Coverage Report for Build 6038243457

  • 40 of 40 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 91.928%

Totals Coverage Status
Change from base Build 6027105370: 0.07%
Covered Lines: 2961
Relevant Lines: 3221

💛 - Coveralls

@caleb-johnson caleb-johnson added this to the 0.4.0 milestone Aug 30, 2023
Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- I am still pondering some things, but this should be enough to get you started.

circuit_knitting/cutting/cutting_evaluation.py Outdated Show resolved Hide resolved
circuit_knitting/cutting/cutting_evaluation.py Outdated Show resolved Hide resolved
circuit_knitting/cutting/cutting_evaluation.py Outdated Show resolved Hide resolved
circuit_knitting/cutting/cutting_evaluation.py Outdated Show resolved Hide resolved
circuit_knitting/cutting/cutting_evaluation.py Outdated Show resolved Hide resolved
@garrison
Copy link
Member

BTW, you might wonder at times why I seem attached to execute_experiments. The first reason is to maintain compatibility with existing workflows, but there is also a second (more important) reason: if in the future we want to provide advanced users the ability to do special things with their experiments (e.g., bin them by weight and then send multiple batches with different shots counts), then we're going to need something that looks a lot like execute_experiments, just with some additional knobs to tweak. Even then, we'll want to expose Qiskit Runtime's Sampler directly in the tutorials so that people gain intuition about how it is used. The execute_experiments function will then be a utility that enables more advanced use of Qiskit Runtime.

Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good; I don't expect to have any further comments once we resolve the open threads.

garrison
garrison previously approved these changes Aug 31, 2023
Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I am happy with this, modulo my one remaining comment.

@caleb-johnson caleb-johnson merged commit 91be0d3 into main Aug 31, 2023
@caleb-johnson caleb-johnson deleted the generate-exp2 branch August 31, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants