-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a public generate_cutting_experiments function #385
Conversation
Pull Request Test Coverage Report for Build 6038243457
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks -- I am still pondering some things, but this should be enough to get you started.
BTW, you might wonder at times why I seem attached to |
Co-authored-by: Jim Garrison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good; I don't expect to have any further comments once we resolve the open threads.
Co-authored-by: Jim Garrison <[email protected]>
…knitting-toolbox into generate-exp2
Co-authored-by: Jim Garrison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I am happy with this, modulo my one remaining comment.
Co-authored-by: Jim Garrison <[email protected]>
This should be the first PR to be merged into
main
based on #352 .This creates a public function
generate_cutting_experiments
which largely mimics the current private function of the same name incutting_evaluation
.