Allow partition_labels to be determined automatically in partition_problem
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrison
added
enhancement
Pull Request Test Coverage Report for Build 5883555891
💛 - Coveralls |
| @@ -26,7 +26,7 @@ | |||
| from qiskit.quantum_info import PauliList | |||
|
|
|||
| from ..utils.observable_grouping import observables_restricted_to_subsystem | |||
| from ..utils.transforms import separate_circuit | |||
| from ..utils.transforms import separate_circuit, _partition_labels_from_circuit | |||
There was a problem hiding this comment.
Maybe we should make this function public in another PR as well?
There was a problem hiding this comment.
Since we're in a time crunch, we can push this through and make that function public next release. I'd be fine with that too. Up to you
|
This is great. I just had one concern about importing the hidden function. I think maybe we leave it as-is for now and consider where the |
Yeah, I think this is the best plan. Thank you for the speedy review! |
caleb-johnson
approved these changes
Aug 16, 2023
This was referenced Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and introduce
TwoQubitQPDGate.from_instruction.I've been working on a PR that introduces a how-to for placing single-qubit wire cuts based on #326. In the course of completing that, I've realized that it would be very nice to have the feature introduced in the current PR, hence its addition to the 0.3 milestone. Hopefully I can convince you quickly of its value 🙂. I'll open the other PR shortly. It doesn't strictly depend on this, but (as you will see when I do), it becomes much nicer with this.