Fix partition_problem
's handling of unlabeled TwoQubitQPDGate
s
#350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when experimenting with
partition_problem
that it blows up if you give it a circuit that contains an unlabeledTwoQubitQPDGate
. In our workflows so far, allTwoQubitQPDGate
s are created withinpartition_problem
itself, as the first thing it does is callpartition_circuit_qubits
, which creates the gates with the labels. However, it's not strictly necessary for the gates to have labels, and people might want to place someTwoQubitQPDGates
manually in addition to the ones across the partition labels. (Also, in the future, we might want to makepartition_labels
optional, at which point it will just partition as well as it can using theTwoQubitQPDGates
that have been placed.)I double checked, and the added test indeed fails without the accompanying change.