Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ObservableCollection.lookup docstring #322

Merged
merged 4 commits into from
Jul 16, 2023
Merged

Conversation

caleb-johnson
Copy link
Collaborator

@caleb-johnson caleb-johnson commented Jul 13, 2023

ckt.utils.observable_grouping.ObservableCollection.lookup docstring intro sentence reads a little vague in the API. Adding a little context to the intro sentence of docstring to make API more clear

@caleb-johnson caleb-johnson added the documentation Improvements or additions to documentation label Jul 13, 2023
@caleb-johnson caleb-johnson requested a review from garrison July 13, 2023 13:44
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Pull Request Test Coverage Report for Build 5568373238

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.713%

Totals Coverage Status
Change from base Build 5532982717: 0.0%
Covered Lines: 2559
Relevant Lines: 2821

💛 - Coveralls

Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@caleb-johnson caleb-johnson changed the title improve docstring improve ObservableCollection.lookup docstring Jul 16, 2023
@caleb-johnson caleb-johnson merged commit a4f902d into main Jul 16, 2023
@caleb-johnson caleb-johnson deleted the util-docstring branch July 16, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants