-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run slow tests for coverage only #317
Conversation
Pull Request Test Coverage Report for Build 5525586771
💛 - Coveralls |
To clarify: this change makes it so coverage run the slow tests by default when invoked by tox; the other tox test environments don't run them. But within CI, the workflows explicitly opt for the other environments to run slow tests as well (see |
Coverage takes a long time to run now, as there is a single test (test_asymmetric_bitstrings_CN) that takes 39 seconds on my machine. I think it might be better to annotate the specific slow functions we actually want to count coverage for, and run only those slow tests during coverage. It might be annoying to figure out the details of this, but I'll probably do it one day when I am feeling especially annoyed by the status quo 🙂 |
OK this had crossed my mind, but now that I see how bad the CN test is again, I'll look into it. Thanks |
#307 includes a slow test that also provides important code coverage. I suggest we run slow tests on coverage only. This will allow us to continue to test a higher proportion of our code without bogging down every workflow with slow tests.