Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update freezing orbitals documentation #315

Merged
merged 9 commits into from
Jul 18, 2023
Merged

Update freezing orbitals documentation #315

merged 9 commits into from
Jul 18, 2023

Conversation

caleb-johnson
Copy link
Collaborator

@caleb-johnson caleb-johnson commented Jul 11, 2023 •
edited
Loading

Defer to how-to in explanatory, rather than duplicating the code block in freezing orbs section of explanatory. Add a reference to explanatory in EFGSSolver init docstring for the orbitals_to_freeze arg.

@coveralls
Copy link

coveralls commented Jul 11, 2023 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 5582174497

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.713%
Totals Coverage Status
Change from base Build 5521596551: 0.01%
Covered Lines: 2559
Relevant Lines: 2821
💛 - Coveralls

@caleb-johnson caleb-johnson requested a review from garrison July 11, 2023 16:32
@caleb-johnson caleb-johnson added documentation Improvements or additions to documentation forging labels Jul 13, 2023
garrison
garrison approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks!

@caleb-johnson caleb-johnson merged commit 74bb91a into main Jul 18, 2023
@caleb-johnson caleb-johnson deleted the freezing-orbs branch July 18, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrison garrison garrison approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caleb-johnson @coveralls @garrison