Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSXGate #296

Merged
merged 4 commits into from
Jun 30, 2023
Merged

CSXGate #296

merged 4 commits into from
Jun 30, 2023

Conversation

garrison
Copy link
Member

@garrison garrison commented Jun 30, 2023 •
edited
Loading

I started with #295, performed a small refactor, and moved the T gate from the second qubit to the first.

@github-actions
Copy link

Pull Request Test Coverage Report for Build 5424346806

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.969%
Totals Coverage Status
Change from base Build 5392811907: 0.02%
Covered Lines: 2350
Relevant Lines: 2612
💛 - Coveralls

caleb-johnson
caleb-johnson approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'm still not sure why this wasn't working in my branch when I tried prepending TGates to qubit 0...

@caleb-johnson caleb-johnson merged commit c3f36e5 into main Jun 30, 2023
@caleb-johnson caleb-johnson deleted the sxgate-jrg branch June 30, 2023 19:14
@caleb-johnson caleb-johnson mentioned this pull request Jun 30, 2023
Closed
@garrison garrison added enhancement New feature or request cutting QPD-based circuit cutting code labels Jun 30, 2023
This was referenced Jun 30, 2023
Merged
Closed
caleb-johnson added a commit that referenced this pull request Jul 5, 2023
@garrison @caleb-johnson
CSXGate (#296)
cf0017a 
* sxgate

* Add t rotation

* Tests pass

* Black

---------

Co-authored-by: Caleb Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleb-johnson caleb-johnson caleb-johnson approved these changes

Assignees
No one assigned
Labels
cutting QPD-based circuit cutting code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garrison @caleb-johnson