Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cut ECRGate #292

Merged
merged 7 commits into from
Jul 1, 2023
Merged

Add support for cut ECRGate #292

merged 7 commits into from
Jul 1, 2023

Conversation

garrison
Copy link
Member

Ref #288. I'll fix this up after #290 is merged.

@garrison garrison added enhancement New feature or request cutting QPD-based circuit cutting code labels Jun 27, 2023
@garrison garrison mentioned this pull request Jun 27, 2023
Closed
11 tasks
@coveralls
Copy link

coveralls commented Jun 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5428093918

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 90.004%
Totals Coverage Status
Change from base Build 5426253917: 0.04%
Covered Lines: 2359
Relevant Lines: 2621
💛 - Coveralls

@garrison garrison marked this pull request as ready for review June 27, 2023 17:38
@garrison garrison marked this pull request as draft June 27, 2023 17:41
@garrison
Copy link
Member Author

I was forced to rebase this because reno did not like that I merged in main and then modified a release note that had just appeared in main. Now CI passes.

@garrison garrison marked this pull request as ready for review June 27, 2023 18:08
@garrison garrison requested a review from caleb-johnson June 27, 2023 18:09
@garrison garrison enabled auto-merge (squash) June 27, 2023 19:17
@garrison garrison disabled auto-merge June 27, 2023 19:17
@garrison garrison mentioned this pull request Jun 30, 2023
Merged
5 tasks
caleb-johnson

This comment was marked as outdated.

Sign in to view

@caleb-johnson
Copy link
Collaborator

Should add this to the "additional-gates" release note

caleb-johnson
caleb-johnson approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , nice to support this one

@garrison garrison enabled auto-merge (squash) July 1, 2023 00:33
@garrison garrison merged commit ea3ce10 into main Jul 1, 2023
@garrison garrison deleted the ecr branch July 1, 2023 00:40
caleb-johnson added a commit that referenced this pull request Jul 5, 2023
@garrison @caleb-johnson
Add support for cut ECRGate (#292)
d907150 
* Add support for cut `ECRGate`

* Let's stop counting the supported operations.

* Add tests for optimal overhead

* Update test/cutting/qpd/test_qpd.py

black fix

* black

* Update release note

---------

Co-authored-by: Caleb Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleb-johnson caleb-johnson caleb-johnson approved these changes

Assignees
No one assigned
Labels
cutting QPD-based circuit cutting code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrison @coveralls @caleb-johnson