Add explicit dependency on rustworkx and scipy #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5380661022
💛 - Coveralls |
garrison
changed the title
|
We can remove the upper bound on scipy once pyscf/pyscf#1771 makes it into a pyscf release. |
caleb-johnson
approved these changes
Jun 26, 2023
caleb-johnson
pushed a commit
that referenced
this pull request
Jul 5, 2023
* Add explicit dependency on rustworkx * Add scipy as well, and pin it from above * Bump to a scipy version compatible with pyscf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #286 in that it adds an explicit dependency on something that we are already importing directly (in this case, rustworkx). I set the minimum version to 0.12.0 since that is what Qiskit Terra 0.24.0 requires.