Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a mixture of exact and sampled weights as appropriate #255

Merged
merged 27 commits into from
Jul 10, 2023
Merged

Return a mixture of exact and sampled weights as appropriate #255

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
3b6aa52
Return a mixture of exact and sampled weights as appropriate
garrison Jun 15, 2023
85129d4
Update outdated comment
garrison Jun 15, 2023
f474828
Use `numpy.nextafter`
garrison Jun 15, 2023
3f55bf4
We might as well sort the output of `generate_qpd_samples`
garrison Jun 16, 2023
bd8785a
Merge branch 'main' into weight-mixture
garrison Jun 21, 2023
767bc11
Test calling `generate_qpd_samples` with 16 cut gates
garrison Jun 21, 2023
91e1dcc
Rename to `generate_qpd_weights`
garrison Jun 21, 2023
ad8dce0
Fix lint
garrison Jun 21, 2023
056d359
Fix lint
garrison Jun 21, 2023
c97aba7
Add docstring for `_populate_samples`
garrison Jun 21, 2023
325cbb6
Improve some docstrings
garrison Jun 22, 2023
7554a8d
More docstring work
garrison Jun 22, 2023
3cdf945
Release note
garrison Jun 22, 2023
3ae4f3c
Asterisks are italics in restructedtext
garrison Jun 22, 2023
bc26d56
Tweaks
garrison Jun 22, 2023
2c3f59c
Merge branch 'main' into weight-mixture
garrison Jun 22, 2023
9f282e0
`probs1` -> `probs`
garrison Jun 22, 2023
5ca4dc7
`runner` -> `running_state`
garrison Jun 22, 2023
5861f99
Remove redundant default arg
garrison Jun 22, 2023
2e7d7b7
Revise release note
garrison Jun 22, 2023
44951d8
Clarifying comments around a branch
garrison Jun 22, 2023
f8ce5d9
Merge branch 'main' into weight-mixture
garrison Jun 27, 2023
da23036
Update documentation about sampling
garrison Jul 5, 2023
9d99317
Black
garrison Jul 5, 2023
8830c94
Address peer review
garrison Jul 5, 2023
665a262
Merge branch 'main' into weight-mixture
garrison Jul 5, 2023
c53fc0b
Peer review
garrison Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions circuit_knitting/cutting/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
:toctree: ../stubs/
:nosignatures:

qpd.generate_qpd_weights
qpd.generate_qpd_samples
qpd.decompose_qpd_instructions
qpd.supported_gates
Expand Down
4 changes: 2 additions & 2 deletions circuit_knitting/cutting/cutting_evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
QPDBasis,
SingleQubitQPDGate,
TwoQubitQPDGate,
generate_qpd_samples,
generate_qpd_weights,
decompose_qpd_instructions,
WeightType,
)
Expand Down Expand Up @@ -259,7 +259,7 @@ def _generate_cutting_experiments(
}

# Sample the joint quasiprobability decomposition
random_samples = generate_qpd_samples(bases, num_samples=num_samples)
random_samples = generate_qpd_weights(bases, num_samples=num_samples)

# Calculate terms in coefficient calculation
kappa = np.prod([basis.kappa for basis in bases])
Expand Down
2 changes: 2 additions & 0 deletions circuit_knitting/cutting/qpd/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

from .qpd_basis import QPDBasis
from .qpd import (
generate_qpd_weights,
generate_qpd_samples,
decompose_qpd_instructions,
WeightType,
Expand All @@ -28,6 +29,7 @@

__all__ = [
"qpdbasis_from_gate",
"generate_qpd_weights",
"generate_qpd_samples",
"decompose_qpd_instructions",
"supported_gates",
Expand Down
Loading