-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note on samping overhead to cutting tutorials #249
Conversation
Pull Request Test Coverage Report for Build 5306859455
💛 - Coveralls |
docs/circuit_cutting/tutorials/01_gate_cutting_to_reduce_circuit_width.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sampling overhead is the required number of samples needed to get an expectation value of a target observable within some error,
$\epsilon$ .
How about:
The sampling overhead is the factor by which the number of samples must increase for the quasiprobability decomposition to result in the same amount of error as one would get by sampling the original circuit.
Hmm your comment doesnt say EDIT: I see it was just a manual quote :) |
docs/circuit_cutting/tutorials/01_gate_cutting_to_reduce_circuit_width.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good. One final thought: I think the word "roughly" may be unnecessary, especially since it is followed by big-O, which is really about asymptotic behavior. I did not even notice this the first five times I read it, so it is a pretty minor point.
I took this from the paper and wondered why it was rough. Is it because different gates have different base terms, or is it because there is something inexact going on with the chosen epsilon? I'm going to remove it since I'm not certain either |
Resolves #225