Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatibility tests of 0.2 circuit cutting workflows #232

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

garrison
Copy link
Member

@garrison garrison commented Jun 1, 2023

This will make sure we don't accidentally break the workflows in the current tutorial notebooks as we tweak the API going forward. We might deliberately break the original workflow, but this should be an intentional choice, not something we do by accident.

@garrison garrison added tests Related to tests cutting QPD-based circuit cutting code labels Jun 1, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5147554023

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.367%

Totals Coverage Status
Change from base Build 5146966568: 0.0%
Covered Lines: 2328
Relevant Lines: 2605

💛 - Coveralls

@garrison
Copy link
Member Author

garrison commented Jun 1, 2023

I inspected the CI logs, and, as expected, all but four tests get run for coverage, and all tests are run for the other workflows.

@garrison garrison requested a review from caleb-johnson June 1, 2023 19:46
@garrison garrison marked this pull request as ready for review June 1, 2023 19:46
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thanks. Love the pytest magic

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thanks. Love the pytest magic

@garrison garrison merged commit 871053a into main Jun 2, 2023
@garrison garrison deleted the 0.2-backwards-compatibility-tests branch June 2, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cutting QPD-based circuit cutting code tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants