Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation of the different tox environments #228

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

garrison
Copy link
Member

@garrison garrison commented Jun 1, 2023

This file is adapted from the quantum-prototype-template.

I am also working on a "developer guide" for the Sphinx docs, which will link to this and a few other files.

Preview at https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/blob/tox-readme/test/README.md

This file is adapted from the quantum-prototype-template.
@coveralls
Copy link

coveralls commented Jun 1, 2023

Pull Request Test Coverage Report for Build 5146466846

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.367%

Totals Coverage Status
Change from base Build 5127839616: 0.0%
Covered Lines: 2328
Relevant Lines: 2605

💛 - Coveralls

@garrison garrison added the documentation Improvements or additions to documentation label Jun 1, 2023
@garrison garrison requested a review from caleb-johnson June 1, 2023 15:57
@garrison garrison marked this pull request as ready for review June 1, 2023 15:58

## Coverage environment

The `coverage` environment uses [Coverage.py] to ensure that the fraction of code tested by pytest is above some threshold (currently set to 80% overall, and 100% in all new modules). A detailed, line-by-line coverage report can be viewed by navigating to `htmlcov/index.html` in a web browser.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice Coverage.py and Jupyter are capitalized in the brackets, but many other packages are not. Also [Black] has the underscores. Are there any principles to capitalization for these packages?

Capitalization aside, do we want to include the file extension for coverage? We don't do that elsewhere here

Copy link
Member Author

@garrison garrison Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the way each package's name is formatted in its own documentation. For instance, https://coverage.readthedocs.io/en/7.2.7/ says "Coverage.py", presumably to disambiguate from other coverage tools. And https://tox.wiki/en/latest/ is without capitalization.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK cool, I figured you followed some principle. Looks great, thanks

@garrison garrison merged commit 2b612c1 into main Jun 1, 2023
@garrison garrison deleted the tox-readme branch June 1, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants