Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak formatting and shots count in how_to_generate_exact_sampling_coefficients.ipynb #205

Merged
merged 4 commits into from
May 27, 2023
Merged

Tweak formatting and shots count in how_to_generate_exact_sampling_coefficients.ipynb #205

merged 4 commits into from
May 27, 2023

Conversation

garrison
Copy link
Member

I'm going to leave this open for a few minutes/hours in case I find any other little adjustments that need made.

@github-actions
Copy link

github-actions bot commented May 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5096513782

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.35%
Totals Coverage Status
Change from base Build 5096504573: 0.0%
Covered Lines: 2324
Relevant Lines: 2601
💛 - Coveralls

@garrison garrison changed the title Tweak formatting in how_to_generate_exact_sampling_coefficients.ipynb Tweak formatting and shots count in how_to_generate_exact_sampling_coefficients.ipynb May 27, 2023
@garrison garrison requested a review from caleb-johnson May 27, 2023 02:22
@garrison
Copy link
Member Author

@caleb-johnson, do you agree with passing shots=1 to the Sampler in this notebook? Do you think it requires any further explanation?

@garrison garrison marked this pull request as ready for review May 27, 2023 03:08
caleb-johnson
caleb-johnson approved these changes May 27, 2023
View reviewed changes
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might go shots=100 to make it clear it's arbitrary.

Maybe what I'm saying makes no sense, but shots=1 seems more specific than shots=100?

lol..anyway looks good, thanks :)

@caleb-johnson caleb-johnson merged commit 5fbc640 into main May 27, 2023
@caleb-johnson caleb-johnson deleted the remaining-tweaks branch May 27, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleb-johnson caleb-johnson caleb-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garrison @caleb-johnson