Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the exact simulator to error on classical conditions #200

Merged
merged 1 commit into from
May 25, 2023
Merged

Fix the exact simulator to error on classical conditions #200

merged 1 commit into from
May 25, 2023

Conversation

garrison
Copy link
Member

Partially addresses #180

This also adds a test to make sure the simulator rejects a circuit with classical control flow, for now.

@garrison
Fix the exact simulator to error on classical conditions
fc851c6 
Partially addresses #180

This also adds a test to make sure the simulator rejects a circuit
with classical control flow, for now.
@garrison garrison added the exact simulator Related to the exact simuator in `circuit_knitting_toolbox/utils/simulation.py` label May 25, 2023
@garrison garrison requested a review from caleb-johnson May 25, 2023 20:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5084465379

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 88.273%
Totals Coverage Status
Change from base Build 5070221586: 0.01%
Covered Lines: 2085
Relevant Lines: 2362
💛 - Coveralls

caleb-johnson
caleb-johnson approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@garrison garrison merged commit f8fe41c into main May 25, 2023
@garrison garrison deleted the exact-simulator-error-on-condition-bits branch May 25, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleb-johnson caleb-johnson caleb-johnson approved these changes

Assignees
No one assigned
Labels
exact simulator Related to the exact simuator in `circuit_knitting_toolbox/utils/simulation.py`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrison @coveralls @caleb-johnson