-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
partition_circuit_qubits #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4953717621
💛 - Coveralls |
2 tasks
2 tasks
Co-authored-by: Jim Garrison <[email protected]> Co-authored-by: Almudena Carrera Vazquez <[email protected]> Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: Daniel Egger <[email protected]> Co-authored-by: Stefan Woerner <[email protected]> Co-authored-by: Jen Glick <[email protected]> Co-authored-by: Pedro Rivero Ramirez <[email protected]> Co-authored-by: Bryce Fuller <[email protected]>
caleb-johnson
force-pushed
the
cutting-module
branch
from
May 11, 2023 23:43
4251f79
to
c7727de
Compare
garrison
reviewed
May 11, 2023
Co-authored-by: Jim Garrison <[email protected]>
garrison
previously approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. If the current version passes tests, I think it is good to merge.
garrison
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #101
Resolves #138
This PR establishes a cutting module in the circuit_cutting package by implementing a
partition_circuit_qubits
function. It assumes cutqc has already been packaged in accordance with #138 , and it assumes the base QPD classes are available as in #137 .This PR was created so we could discuss the arrangement of the packages, modules, and CI while we finalize the implementation internally.