Install *all* notebook dependencies in the Dockerfile #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs all the notebook dependencies given in
pyproject.toml
instead of listing a few explicitly. Thus, this means (i) less code duplication; and (ii) all notebooks will work when used inside Docker.I had to wonder for a moment why I didn't just do this originally when the
Dockerfile
was added as part of #2. Here's why: Then, the quantum-serverless repository was private, and there was no simple & secure way that we knew of for users to pass their ssh private key to the Docker build. So, we simply did not install quantum-serverless within Docker at the time.I've tested each tutorial notebook locally (and within Docker) with this change, and they all work.