Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install *all* notebook dependencies in the Dockerfile #112

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

garrison
Copy link
Member

This installs all the notebook dependencies given in pyproject.toml instead of listing a few explicitly. Thus, this means (i) less code duplication; and (ii) all notebooks will work when used inside Docker.

I had to wonder for a moment why I didn't just do this originally when the Dockerfile was added as part of #2. Here's why: Then, the quantum-serverless repository was private, and there was no simple & secure way that we knew of for users to pass their ssh private key to the Docker build. So, we simply did not install quantum-serverless within Docker at the time.

I've tested each tutorial notebook locally (and within Docker) with this change, and they all work.

@garrison garrison requested a review from caleb-johnson April 13, 2023 00:56
@github-actions
Copy link

Pull Request Test Coverage Report for Build 4684339495

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.59%

Totals Coverage Status
Change from base Build 4672713865: 0.0%
Covered Lines: 1515
Relevant Lines: 1791

💛 - Coveralls

@garrison garrison mentioned this pull request Apr 13, 2023
2 tasks
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeeeet 👍

@garrison garrison merged commit 43eaa2f into main Apr 13, 2023
@garrison garrison deleted the dockerfile-all-nb-deps branch April 13, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants