Skip to content

Commit

Permalink
Don't assume we are on the main branch when collecting release notes
Browse files Browse the repository at this point in the history
  • Loading branch information
garrison committed Jun 26, 2023
1 parent 0f08ee8 commit 70434d6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ jobs:
pip install tox
sudo apt-get update
sudo apt-get install -y pandoc
- name: Tell reno to name the upcoming release after the branch we are on
shell: bash
run: |
sed -i.bak -e '/unreleased_version_title:*/d' releasenotes/config.yaml
echo unreleased_version_title: \"Upcoming release \(\`\`${GITHUB_REF_NAME}\`\`\)\" >> releasenotes/config.yaml
- name: Build docs
shell: bash
run: |
Expand Down
2 changes: 1 addition & 1 deletion releasenotes/config.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
encoding: utf8
default_branch: main
unreleased_version_title: "Upcoming release (``main`` branch)"
unreleased_version_title: "Upcoming release"
earliest_version: 0.1.0

1 comment on commit 70434d6

@garrison
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally pushed this to main instead of making a PR. I thought the branch protection rule would prevent this, but I guess it allows it since I am a repository admin (:joy:).

Since we build our docs from a stable branch now, the goal here is for them to say the name of the correct stable branch instead of main in the release notes. I want to start maintaining the stable backports at some point (probably after the 0.3 release), and it will be better to have this correctly labeled by then.

Please sign in to comment.