Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

update strings to be translated #1611

Merged
merged 3 commits into from
Oct 4, 2022
Merged

update strings to be translated #1611

merged 3 commits into from
Oct 4, 2022

Conversation

vabarbosa
Copy link
Contributor

@vabarbosa vabarbosa commented Oct 4, 2022 •
edited
Loading

Changes

this PR updates the strings.yaml that will be used for translating non-notebook text that appear throughout the platform

Implementation details

  • sorted the default (English) strings.yaml
  • updated the Japanese strings.yaml to include some of the missing strings
  • added the Spanish strings.yaml for translation
  • added the Portuguese strings.yaml for translation
  • added the Korean strings.yaml for translation

How to read this PR

review the strings.yaml make sure format is correct

@vabarbosa vabarbosa requested a review from a team as a code owner October 4, 2022 18:54
@vabarbosa vabarbosa removed the request for review from a team October 4, 2022 18:54
@clausia
Copy link
Contributor

clausia commented Oct 4, 2022

😃

Thanks!

techtolentino
techtolentino previously approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@techtolentino techtolentino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vabarbosa vabarbosa merged commit a5c3bbd into main Oct 4, 2022
@vabarbosa vabarbosa deleted the i18n-strings branch October 4, 2022 19:22
@vabarbosa vabarbosa mentioned this pull request Oct 4, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techtolentino techtolentino techtolentino left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vabarbosa @clausia @techtolentino