Last updates to Intro to Qiskit and what are patterns pages #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankharkins
approved these changes
Jun 10, 2024
abbycross
reviewed
Jun 10, 2024
abbycross
reviewed
Jun 10, 2024
abbycross
reviewed
Jun 10, 2024
| ### Circuit building tools | ||
| ([`qiskit.circuit`](/api/qiskit/circuit)) | ||
| For initializing and manipulating registers, circuits, instructions, gates, parameters, and control flow objects. | ||
| - Circuit building tools ([`qiskit.circuit`](/api/qiskit/circuit)) - For initializing and manipulating registers, circuits, instructions, gates, parameters, and control flow objects. |
There was a problem hiding this comment.
Suggested change
| - Circuit building tools ([`qiskit.circuit`](/api/qiskit/circuit)) - For initializing and manipulating registers, circuits, instructions, gates, parameters, and control flow objects. | |
| - Circuit-building tools ([`qiskit.circuit`](/api/qiskit/circuit)) - For initializing and manipulating registers, circuits, instructions, gates, parameters, and control flow objects. |
abbycross
reviewed
Jun 10, 2024
| ### Quantum Information | ||
| ([`qiskit.quantum_info`](/api/qiskit/quantum_info)) | ||
| A toolkit for working with quantum states, operators and channels, using exact calculations (no sampling noise). Use this module to specify input observables and analyse fidelity of outputs from primitives queries. | ||
| - Quantum Information ([`qiskit.quantum_info`](/api/qiskit/quantum_info)) - A toolkit for working with quantum states, operators and channels, using exact calculations (no sampling noise). Use this module to specify input observables and analyse fidelity of outputs from primitives queries. |
There was a problem hiding this comment.
Suggested change
| - Quantum Information ([`qiskit.quantum_info`](/api/qiskit/quantum_info)) - A toolkit for working with quantum states, operators and channels, using exact calculations (no sampling noise). Use this module to specify input observables and analyse fidelity of outputs from primitives queries. | |
| - Quantum information ([`qiskit.quantum_info`](/api/qiskit/quantum_info)) - A toolkit for working with quantum states, operators, and channels, using exact calculations (no sampling noise). Use this module to specify input observables and analyze fidelity of outputs from primitives queries. |
There was a problem hiding this comment.
Not sure if the "I" in Information should be capitalized as part of a package name or not - suggesting the change here since we try to keep things lower-case as much as possible, but feel free to change it back
abbycross
reviewed
Jun 10, 2024
| ### Transpiler | ||
| ([`qiskit.transpiler`](/api/qiskit/transpiler)) | ||
| For transforming and adapting quantum circuits to suit specific device topology and/or optimizing for execution on real quantum systems. | ||
| - Transpiler ([`qiskit.transpiler`](/api/qiskit/transpiler)) - For transforming and adapting quantum circuits to suit specific device topology and/or optimizing for execution on real quantum systems. |
There was a problem hiding this comment.
Suggested change
| - Transpiler ([`qiskit.transpiler`](/api/qiskit/transpiler)) - For transforming and adapting quantum circuits to suit specific device topology and/or optimizing for execution on real quantum systems. | |
| - Transpiler ([`qiskit.transpiler`](/api/qiskit/transpiler)) - For transforming and adapting quantum circuits to suit specific device topology, and optimizing for execution on real quantum systems. |
There was a problem hiding this comment.
(avoiding and/or bc it doesn't translate well)
abbycross
approved these changes
Jun 10, 2024
Co-authored-by: abbycross <[email protected]>
This was
linked to
issues
Jun 17, 2024
abbycross
reviewed
Jun 17, 2024
abbycross
reviewed
Jun 17, 2024
|
|
||
|
|
||
| --- | ||
|
|
||
|
|
||
| As we move from bespoke circuit construction to utility-scale workflows, the flexibility and ease with which Qiskit Patterns allows one to compose the different steps of the pattern opens quantum computing to a wide variety of applications and techniques for easy use by quantum computational scientists. | ||
| As the field moves from bespoke circuit construction to utility-scale workflows, the flexibility and ease with which Qiskit patterns allow users to compose the different steps of the pattern opens quantum computing to a wide variety of applications and techniques for easy use by quantum computational scientists. |
There was a problem hiding this comment.
flagging this fix I made (from "As we move" to "As the field moves") to avoid using "we" -- making sure it's palatable or maybe there's a better way to reword it @javabster
abbycross
reviewed
Jun 17, 2024
abbycross
reviewed
Jun 17, 2024
There was a problem hiding this comment.
I didn't review the content itself - but the infra-side looks good!
Could you please organize the images better to be like public/images/qiskit-patterns/map.svg, ../qiskit-patterns/overview.svg, etc? We want to use folders with public/images so that it's more organized.
Eric-Arellano
approved these changes
Jun 18, 2024
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
) Just added some images and did some reformatting --------- Co-authored-by: abbycross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added some images and did some reformatting