增加集群和命名空间级别自定义注解 #274
Merged
增加集群和命名空间级别自定义注解 #274
+135
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhelmguo
added
the
kind/feature
chengyumeng
reviewed
Feb 15, 2019
chengyumeng
reviewed
Feb 15, 2019
|
@wilhelmguo @chengyumeng fix it |
wilhelmguo
reviewed
Feb 18, 2019
| preDefinedAnnotationMap[k] = v | ||
| } | ||
| // cluster defined, overwrite user defined | ||
| for k, v := range cluster.MetaDataObj.ServiceAnnotations { |
There was a problem hiding this comment.
ingress 为什么引用 ServiceAnnotations ？
wilhelmguo
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
to use wayne in public cloud env.