Question

[PKEv]

I do not know how to, but the inclusion of a resource file under version control does not seem quite right to me.
Now this file each time you create a new, even if there were no changes to the image files
What do you think?
@oroulet

[oroulet]

In theory should not resource files be under version control. We should generate them with a Makefile or py file.
Btw, how do I use the image repository and generate the resource file now? I still have the old delete icon
Thanks
Olivier

[PKEv]

1)In that case I exclude files Images\white\qTodoTxt_style_rc.py and Images\dark\qTodoTxt_dark_style_rc.py from the repository "Images"

2)at this moment you need

1. run scripts : Images\white\compile.py and Images\dark\compile.py
2. copy files: Images\white\qTodoTxt_style_rc.py and Images\dark\qTodoTxt_dark_style_rc.py to QTodoTxt\qtodotxt\ui\resources\

3)I update program by QTodoTxt/QTodoTxt#369 now all must work

[oroulet]

maybe we should creare a script called update_resources.py in QTodotxt that
checks if the images repository exist, if not clone it, then generate the
*style_rc.py files

On Mon, 21 Nov 2016 at 14:51 PKEv [email protected] wrote:

1. In that case I exclude files Images\white\qTodoTxt_style_rc.py and
   Images\dark\qTodoTxt_dark_style_rc.py from the repository "Images"

2)at this moment you need

1. run scripts : Images\white\compile.py and Images\dark\compile.py
2. copy files: Images\white\qTodoTxt_style_rc.py and
   Images\dark\qTodoTxt_dark_style_rc.py to QTodoTxt\qtodotxt\ui\resources\
3. I update program by Updating resources QTodoTxt#369
   Updating resources QTodoTxt#369 now all must work

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACcfzsZwghfHoZnBBcWlduqBpvfmbWKjks5rAaHSgaJpZM4KxTxm
.

[PKEv]

I do not quite understand your ideas
because the repository may not necessarily be adjacent to or do you propose to do Github hook? I do not know much about them...

[oroulet]

Ideally we could use subrepositories, but they are complicated. So I
propose to require to clone images inside qtodotxt repository. We can just
document this. This is very common.

On Mon, Nov 21, 2016, 15:37 PKEv [email protected] wrote:

I do not quite understand your ideas
because the repository may not necessarily be adjacent to or do you
propose to do Github hook? I do not know much about them...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACcfzuw5uIfRTvh-Q1d7sBB0IA4etGYiks5rAayIgaJpZM4KxTxm
.

[PKEv]

What do you think about the use of the service to compile resources and create push commit to qtodotxt like in these instructions: https://gist.github.com/domenic/ec8b0fc8ab45f39403dd

[PKEv]

resources not change frequently, and the use of compiled resources, improves the stability program

[oroulet]

I propose to not have the compiled files under git at all

On Mon, Nov 21, 2016, 21:13 PKEv [email protected] wrote:

resources not change frequently, and the use of compiled resources,
improves the stability program

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACcfzk1oRzykaSlrqYpR_U7H534mp7svks5rAft2gaJpZM4KxTxm
.