Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Multi] make changes to rely on ADL get instead of std::get" #5236

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Revert "[Multi] make changes to rely on ADL get instead of std::get" #5236

merged 2 commits into from
Nov 21, 2024

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Nov 21, 2024

Reverts #5228

@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 21, 2024

Test this please

@ye-luo ye-luo mentioned this pull request Nov 21, 2024
Merged
prckent
prckent approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable / Not practical to review / Easy to rerevert

@prckent prckent merged commit 8becaf9 into develop Nov 21, 2024
36 of 39 checks passed
@ye-luo ye-luo deleted the revert-5228-correaa-patch-use-adl-get branch November 21, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ye-luo @prckent