Drop FindBoost module which is deprecated in CMake 3.30 and raise minimum version to 1.70. #5227
Conversation
|
Test this please |
There was a problem hiding this comment.
Thanks for looking at this. I have been wondering about the boost cmake change for some time since we have been getting warnings on cdash from the nightlies.
Since this PR breaks multiple CI configurations, we can conclude that not only are we not ready for the change in the current version of the PR, but it will also cause headaches for existing users which we can easily avoid: I suggest to simply use the new find_package mechanisms for cmake >=3.30.0 otherwise use the old scheme.
If CMake 3.30.0 needs a specific minimum boost we can use that boost minimum version for CMake 3.30.0. => For CMake 3.30.0 we require 1.70.0, otherwise I we support the old route and old minimum version. This avoids creating work for no obvious benefit.
(Something to discuss for the rainy day list would would be to have boost as an optional dependency for real space builds. Removing a dependency would definitely make things easier for users. Currently optional LMY_ENGINE and AFQMC need it in many places, but we only make a little use elsewhere.)
|
I don't think I've touched a boost tarball for a decade. Either it is a distro package or I use spack. And at least for spack I had to pull a newer version of spack and reinstall boost. My old install did not include the cmake config files for any version of spack. I can see the recipe for boost has been updated. So I think that's probably a possible issue here. Once I've done that it works fine. I don't think spack was ever correct to leave these files out. |
|
I'd add I'm using [email protected] was using [email protected] installed months ago and reinstalled after a pull of spack develop today. So this works with older cmake's but maybe not if you have a old spack install of boost even if its far newer that 1.70 On osx homebrew looks to be installing boost properly. |
|
(Not changing my view here - needs updating to use the new find_package mechanisms for cmake >=3.30.0 otherwise use the old scheme. This is the least disruptive approach.) |
|
@PDoakORNL boost issue fixed by spack/spack#46281 and spack/spack#46062 Aug/Sep 2024. So only recently. |
…imum version to 1.70 (2019). Instead of the CMake shipped module file, upstream Boost's BoostConfig.cmake package configuration file will be used. This change requires installing boost but we only need the "headers" library. Installation of boost headers is very simple and quick ./bootstrap.sh --prefix=<location of your installation> --with-libraries=headers ./b2 install QMCPACK CMake takes -DBOOST_ROOT=<location of your installation> as usual.
|
For CMake version < 3.30, keep using the boost module. |
|
Test this please |
|
Test this please |
|
Thanks Ye! |
|
Test this please |
Proposed changes
Boost 1.70 was release in 2019.
Instead of the CMake shipped module file, upstream Boost's BoostConfig.cmake package configuration file will be used.
This change requires installing boost properly but we only need the "headers" library. Untaring a boost archive won't work.
Installation of boost headers is very simple and quick
QMCPACK CMake takes
-DBOOST_ROOT=<location of your installation>as usual.What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
laptop
Checklist