Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More restructuring of spline reader classes #4851

Merged
merged 10 commits into from
Dec 1, 2023
Merged

More restructuring of spline reader classes #4851

merged 10 commits into from
Dec 1, 2023

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Nov 30, 2023 •
edited
Loading

Proposed changes

  1. Put OneSplineOrbData in its own class
  2. Introduce cpp file for Move header only class. HybridRepSetReader.cpp and SplineSetReader.cpp.

A lot of spaghetti cleaning. About to touch HybridRep classes next.

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

laptop

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted

@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 30, 2023

Test this please

@prckent
Copy link
Contributor

prckent commented Dec 1, 2023

Test this please

@prckent prckent enabled auto-merge December 1, 2023 01:01
@prckent prckent merged commit 09203fe into QMCPACK:develop Dec 1, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ye-luo @prckent