-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update batched matrix inversion and update frontier recipe #4742
Conversation
Restore hipBLAS.hip.cpp to hipBLAS.cpp as a pure CXX source file with HIP kernels removed.
@jakurzak I was reading #3341 (comment). What is the current behavior of hipblas?getrfBatched() and hipblas?getriBatched()? Are they unconditionally hitting the non-pivoting case or they behave like cuBLAS selecting code path depending on whether the pointer is nullptr? In the former case, the current code is good. In the latter case, we may further simplify the code in QMCPACK. |
Test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with asserts is that they are only active in debug builds. We don't have any ROCm debug builds in testing. Throw an exception instead?
Agreed. It is pure C++ now and thus exception is better. I was concerned of C++ and HIP interaction. |
Test this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simpler.
rtd build for nexus docs is sick but this PR does not touch any docs. Hopefully a transient problem.
Proposed changes
Resolves #4741 by deleting the non-pivoting code path that needs kernels.
The non-pivoting case was needed likely by the legacy CUDA which was deleted.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist