Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sycl event usage #4738

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Remove sycl event usage #4738

merged 4 commits into from
Sep 19, 2023

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Sep 19, 2023

Proposed changes

Since we use in-order queue, there is no need to use events for expressing dependency.

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

sunspot

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

prckent
prckent approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this workaround works.

@prckent
Copy link
Contributor

prckent commented Sep 19, 2023

Test this please

@prckent prckent enabled auto-merge September 19, 2023 01:58
@prckent prckent merged commit a39c00d into QMCPACK:develop Sep 19, 2023
23 checks passed
@ye-luo ye-luo deleted the remove-sycl-events branch October 31, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ye-luo @prckent