Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] implement necessary uninitcopy #4735

Closed

Conversation

correaa
Copy link
Contributor

@correaa correaa commented Sep 17, 2023

Proposed changes

to fight ADL-unfriendly types used in AFQMC

This change is necessary for multi to be able to call uninitialized_copy generically from subarray -> array construction

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@correaa correaa changed the title [draft] implement necessary uninitcopy [WIP] implement necessary uninitcopy Sep 17, 2023
@PDoakORNL
Copy link
Contributor

So is this PR still alive?

@correaa
Copy link
Contributor Author

correaa commented May 8, 2024

this is either solved or outdated. can be closed.

@correaa correaa closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants