Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninitcopy for device pointer #4727

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

correaa
Copy link
Contributor

@correaa correaa commented Sep 13, 2023

Proposed changes

This change is necessary for multi to be able to call uninitialized_copy generically from subarray -> array construction

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

this change is necessary for multi to be able to call uninitcopy generically from subarray -> array construction
@prckent
Copy link
Contributor

prckent commented Sep 13, 2023

Does this affect any existing functionality? If so, please explain.

@prckent
Copy link
Contributor

prckent commented Sep 13, 2023

Test this please

@correaa
Copy link
Contributor Author

correaa commented Sep 13, 2023

Does this affect any existing functionality? If so, please explain.

Refactoring (no functional changes). I updated the description above.

@prckent
Copy link
Contributor

prckent commented Sep 13, 2023

Thanks any insights into the reported problems on NV? e.g. You see problems in testing?

@prckent prckent enabled auto-merge September 13, 2023 13:39
@prckent prckent merged commit c8ac85d into QMCPACK:develop Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants