Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use new GitHub Pages workflow instead of gh-pages branch #320

Merged
merged 1 commit into from
Jan 19, 2024
Merged

docs: use new GitHub Pages workflow instead of gh-pages branch #320

merged 1 commit into from
Jan 19, 2024

Conversation

Guts
Copy link
Contributor

@Guts Guts commented Jan 11, 2024 •
edited
Loading

In this PR :

  • rely on modern GitHub Pages deployment through GitHub Actions instead of pushing to a specific branch (gh-pages). A cleaner behavior, similar to GitLab Pages.
  • improve documentation workflow to build also on PR but not deploy
  • remove ghp-import dependency since it's not necessary anymore

After merging this one, remember to remove gh-pages branch and switch to beta GitHub Actions in https://github.com/QGIS-Contribution/QGIS-ResourceSharing/settings/pages

image

@Guts Guts added this to the Grant Oslandia (2024T1) milestone Jan 11, 2024
@Guts Guts requested a review from ptitjano January 11, 2024 10:32
@Guts Guts self-assigned this Jan 11, 2024
@github-actions github-actions bot added documentation Issues with the documentation of the plugin dependencies ci-cd Everything related to continuous integration and deployment labels Jan 11, 2024
@Guts Guts force-pushed the docs/move-to-modern-github-pages-workflow branch from e247b8e to 6f6cc27 Compare January 19, 2024 17:07
ptitjano
ptitjano approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@ptitjano ptitjano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @Guts

@Guts Guts force-pushed the docs/move-to-modern-github-pages-workflow branch from 6f6cc27 to 97bbf92 Compare January 19, 2024 17:31
@Guts Guts enabled auto-merge January 19, 2024 17:31
@Guts Guts merged commit 2a85acd into master Jan 19, 2024
3 of 4 checks passed
@Guts Guts deleted the docs/move-to-modern-github-pages-workflow branch January 19, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitjano ptitjano ptitjano approved these changes

Assignees

@Guts Guts

Labels
ci-cd Everything related to continuous integration and deployment dependencies documentation Issues with the documentation of the plugin
Projects
None yet
Milestone
Grant Oslandia (2024S1)
Development

Successfully merging this pull request may close these issues.
2 participants
@Guts @ptitjano