-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Restructure unbalanced OT module #658
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 96.85% 96.88% +0.03%
==========================================
Files 88 93 +5
Lines 17910 18166 +256
==========================================
+ Hits 17346 17600 +254
- Misses 564 566 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @6Ulm for this nice cleaning and new features. Follows some comments and you forgot to update the release.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank your for your updates @6Ulm.
Types of changes
This PR aims to improve the current module
unbalanced.py
on two aspects:reg_type=kl
) or one-matrix (forreg_type=entropy
). With trivial modification, we can allow for any nonnegative reference measure. This will be useful for theot.solve
, since we consider a very generic unbalanced OT problem.Major changes:
reg_type=kl
, allow for any reference measurec
in the regularization term (ot.unbalanced.lbfgsb_unbalanced2
, which returns the UOT loss. This is consistent with other solvers in POT.Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist