-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature ancestry #598
Feature ancestry #598
Changes from 5 commits
33c53ff
82f7fee
d105848
3350375
6a69ddd
a5fb7dc
dcf8163
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -207,6 +207,10 @@ def __init__(self, pattern, markdown_instance=None): | |
if markdown_instance: | ||
self.markdown = markdown_instance | ||
|
||
def getExcludes(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason why this is a method? The end user of API (extension developer) is defining a list, not "getting" the list. The fact that the list is being retrieved is not relevant to the user. Rather, the user is interested in defining what to exclude. Why not a property There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Something like To be safe, we can probably just wrap the treeprocessor access with a try/except to be safe as well. |
||
"""Get tag to exclude.""" | ||
return [] | ||
|
||
def getCompiledRegExp(self): | ||
""" Return a compiled regular expression. """ | ||
return self.compiled_re | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Returns an array... tag names in the list." Let's be consistent here. And in Python we call them lists, not arrays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I work in many languages, so things blur together at times and I make mistakes like this.