Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Octeract from the list of expected NEOS solvers (and other infrastructure fixes) #3374

Merged
merged 18 commits into from
Oct 3, 2024

Conversation

jsiirola
Copy link
Member

@jsiirola jsiirola commented Sep 20, 2024

Fixes # .

Summary/Motivation:

As of 19 Sept it appears that Octeract has been removed from the list of AMPL solvers on NEOS. This PR tracks that change so that our tests continue to run/pass.

While fixing the Octeract issue a number of other infrastructure issues cropped up so this PR also includes several small fixes for those.

Changes proposed in this PR:

  • Remove expectation that 'octeract' is in the list of NEOS solvers with AMPL interfaces
  • Pin setuptools to <74.0.0 for windows due to an issue with compiling APPSI
  • Switch to macos-latest runner on GHA
  • Remove degeneracy from GDP book example
  • Update a fragile test in kernel Delaunay triangulation
  • Add a slight negative tolerance to post processing in FME test to address a numerical issue

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@jsiirola jsiirola requested review from blnicho and mrmundt September 20, 2024 09:32
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (df51e99) to head (ad049f4).
Report is 929 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3374   +/-   ##
=======================================
  Coverage   88.63%   88.63%           
=======================================
  Files         879      879           
  Lines      100221   100221           
=======================================
  Hits        88827    88827           
  Misses      11394    11394           
Flag Coverage Δ
linux 86.27% <ø> (ø)
osx 75.64% <ø> (-0.40%) ⬇️
other 86.76% <ø> (-0.01%) ⬇️
win 84.02% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh look, and Windows is still not fine.

@blnicho blnicho changed the title Remove Octeract from the list of expected NEOS solvers Remove Octeract from the list of expected NEOS solvers (and other infrastructure fixes) Oct 3, 2024
@jsiirola jsiirola merged commit f32f122 into Pyomo:main Oct 3, 2024
32 checks passed
@jsiirola jsiirola deleted the neos-octeract branch October 3, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants